Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(2353): ScaleButton disabled propagating #2375

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Fix(2353): ScaleButton disabled propagating #2375

merged 2 commits into from
Jan 22, 2025

Conversation

glebbo-dev
Copy link
Contributor

@glebbo-dev glebbo-dev commented Dec 12, 2024 •
edited by amir-ba
Loading

Fixes #2353
The accessibility issue was fixed by removing disabled attribute from scale-button when disabled status changes to false.

@netlify Netlify
Copy link

netlify bot commented Dec 12, 2024 •
edited
Loading

❌ Deploy Preview for marvelous-moxie-a6e2fe failed.

Name Link
🔨 Latest commit 5685b25
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/678fa79f3b4684000878d763

@amir-ba
Copy link
Collaborator

amir-ba commented Jan 22, 2025

LGTM, thanks for the change. I will merge this

@amir-ba amir-ba merged commit 0874436 into telekom:main Jan 22, 2025
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amir-ba amir-ba amir-ba left review comments

@maomaoZH maomaoZH Awaiting requested review from maomaoZH maomaoZH is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ScaleButton disabled propagating
2 participants
@glebbo-dev @amir-ba